OCP4: Don't use a list in platforms #8852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: |
jhrozek
force-pushed
the
no_list_in_platforms
branch
from
7a75beb to
ffde1e4
Compare
|
/hold |
JAORMX
approved these changes
May 31, 2022
|
@jhrozek what's the issue? |
The list notation doesn't work anymore, let's use a boolean "sentence" instead. Related: ComplianceAsCode#8833
jhrozek
force-pushed
the
no_list_in_platforms
branch
from
ffde1e4 to
c46cd0b
Compare
|
/hold cancel |
|
An error occurred when fetching issues. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 26.1% (0.0% change). View more on Code Climate. |
|
/retest |
|
The code change is trivial and was previously acked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The list notation doesn't work anymore, let's use a boolean "sentence"
instead.
Rationale:
Related: #8833