-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCP: Add vaiabled support for kubelet_configure_tls_cipher_suites #8332
Conversation
This datastream diff is auto generated by the check Click here to see the full diffPlatform #ocp4.10 not defined in platform specification
Platform #ocp4.10 not defined in platform specification
Platform #ocp4.7 not defined in platform specification
Platform #ocp4.7 not defined in platform specification |
47b3190
to
37e5278
Compare
/retest |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you. Just one small grammar nit and then we're good to go.
applications/openshift/kubelet/kubelet_configure_tls_cipher_suites/rule.yml
Outdated
Show resolved
Hide resolved
User can choose which cipher to be used by setting two variable, var_kubelet_tls_cipher_suites_regex, and var_kubelet_tls_cipher_suites Add regex varaible support to yamlfile_value template
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
sorry for the late review, I thought I had already acked the PR
User can choose which cipher to be used by setting two variable, var_kubelet_tls_cipher_suites_regex, and var_kubelet_tls_cipher_suites