Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP: Add vaiabled support for kubelet_configure_tls_cipher_suites #8332

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

Vincent056
Copy link
Contributor

User can choose which cipher to be used by setting two variable, var_kubelet_tls_cipher_suites_regex, and var_kubelet_tls_cipher_suites

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

@github-actions
Copy link

github-actions bot commented Mar 11, 2022

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
Platform #ocp4.10 not defined in platform specification
Platform #ocp4.10 not defined in platform specification
Platform #ocp4.7 not defined in platform specification
Platform #ocp4.7 not defined in platform specification

@Vincent056
Copy link
Contributor Author

/retest

@Vincent056
Copy link
Contributor Author

/test all

Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thank you. Just one small grammar nit and then we're good to go.

User can choose which cipher to be used by setting two variable, var_kubelet_tls_cipher_suites_regex, and var_kubelet_tls_cipher_suites

Add regex varaible support to yamlfile_value template
@jhrozek
Copy link
Collaborator

jhrozek commented Mar 14, 2022

/retest

Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
sorry for the late review, I thought I had already acked the PR

@Vincent056 Vincent056 merged commit c5ba108 into ComplianceAsCode:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants