-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCP4: Add SI-6(d) compliance_notification_enabled #8014
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/comliance/compliance/g
This needs to be fixed in both the file name and instances of text.
applications/openshift/general/comliance_notification_enabled/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/general/comliance_notification_enabled/tests/have_prometheus.pass.sh
Outdated
Show resolved
Hide resolved
applications/openshift/general/comliance_notification_enabled/rule.yml
Outdated
Show resolved
Hide resolved
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll inspect CI to make sure this specific rule passes.
@Vincent056: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Added rule
compliance_notification_enabled
to check if a Prometheus rule object is created by Compliance Operator