Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP4: Add SI-6(d) compliance_notification_enabled #8014

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented Dec 20, 2021

Added rule compliance_notification_enabled to check if a Prometheus rule object is created by Compliance Operator

@JAORMX
Copy link
Contributor

JAORMX commented Dec 21, 2021

/retest

Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/comliance/compliance/g This needs to be fixed in both the file name and instances of text.

@Vincent056 Vincent056 changed the title OCP4: Add SI-6(d) comliance_notification_enabled OCP4: Add SI-6(d) compliance_notification_enabled Dec 21, 2021
@JAORMX
Copy link
Contributor

JAORMX commented Dec 21, 2021

/retest

Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll inspect CI to make sure this specific rule passes.

@openshift-ci
Copy link

openshift-ci bot commented Dec 21, 2021

@Vincent056: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-moderate-node 851ee63 link true /test e2e-aws-ocp4-moderate-node
ci/prow/e2e-aws-ocp4-cis 851ee63 link true /test e2e-aws-ocp4-cis
ci/prow/e2e-aws-ocp4-pci-dss 851ee63 link true /test e2e-aws-ocp4-pci-dss
ci/prow/e2e-aws-ocp4-moderate 851ee63 link true /test e2e-aws-ocp4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JAORMX JAORMX merged commit 87de967 into ComplianceAsCode:master Dec 22, 2021
@yuumasato yuumasato added this to the 0.1.60 milestone Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants