Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocp4 test YAML manifests for two sshd rules #8007

Closed
wants to merge 1 commit into from

Conversation

jhrozek
Copy link
Collaborator

@jhrozek jhrozek commented Dec 16, 2021

Description:

  • just adds tests

Rationale:

We had a bug in the compliance operator where several SSHD related
remediations were not rendered and we didn't notice. Having e2e test
blurbs for the rules would have helped us to catch the issues earlier.

@Mab879
Copy link
Member

Mab879 commented Dec 16, 2021

/retest

@JAORMX
Copy link
Contributor

JAORMX commented Dec 17, 2021

Seems there is a legitimate failure:

     helpers.go:805: Result - Name: e2e-moderate-master-sshd-set-idle-timeout - Status: FAIL - Severity: medium
    helpers.go:808: E2E-FAILURE: The expected result for the sshd_set_idle_timeout rule didn't match. Expected 'PASS', Got 'FAIL' 

@matejak
Copy link
Member

matejak commented Jan 3, 2022

/retest

1 similar comment
@Mab879
Copy link
Member

Mab879 commented Mar 7, 2022

/retest

@jan-cerny
Copy link
Collaborator

@jhrozek Now it shows that "All checks have passed". Does it mean that it's OK to merge this?

@Mab879
Copy link
Member

Mab879 commented May 16, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 16, 2022

@jhrozek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-high 6278491 link true /test e2e-aws-rhcos4-high

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JAORMX
Copy link
Contributor

JAORMX commented May 17, 2022

The failure is unrleated, and it seems that another rule broke the ocp4-high test:

    helpers.go:814: E2E-FAILURE: The expected result for the sysctl_kernel_core_pattern rule didn't match. Expected 'PASS', Got 'FAIL'

@jhrozek @Mab879 could you check that out? ^^

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented May 17, 2022

Code Climate has analyzed commit fa770f3 and detected 0 issues on this pull request.

View more on Code Climate.

@Mab879 Mab879 self-assigned this May 17, 2022
@Mab879
Copy link
Member

Mab879 commented May 17, 2022

@jhrozek The description doesn't seem to match the changes now. This PR no longer adds tests; it just seems to fix some typos.

@jhrozek
Copy link
Collaborator Author

jhrozek commented May 17, 2022

ugh, I pushed to the wrong branch (I shouldn't have called my branch misc should I?). I'll just start over with more descriptive names. Closing.

@jhrozek jhrozek closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants