-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ocp4 test YAML manifests for two sshd rules #8007
Conversation
/retest |
Seems there is a legitimate failure:
|
/retest |
1 similar comment
/retest |
@jhrozek Now it shows that "All checks have passed". Does it mean that it's OK to merge this? |
/retest |
@jhrozek: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
s/rationle/rationale/
Code Climate has analyzed commit fa770f3 and detected 0 issues on this pull request. View more on Code Climate. |
@jhrozek The description doesn't seem to match the changes now. This PR no longer adds tests; it just seems to fix some typos. |
ugh, I pushed to the wrong branch (I shouldn't have called my branch misc should I?). I'll just start over with more descriptive names. Closing. |
Description:
Rationale:
We had a bug in the compliance operator where several SSHD related
remediations were not rendered and we didn't notice. Having e2e test
blurbs for the rules would have helped us to catch the issues earlier.