Fix utils/rule_dir_json.py when no product is detected when rendering OVAL
#7978
Conversation
…ng OVAL `ssh/oval.py`'s `applicable_platform` fails in some cases where a product is not detected since it needs to be rendered in jinja. This adds a parameter that passes the product name and takes it into use in `utils/rule_dir_json.py`. Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
| @@ -117,7 +117,7 @@ def handle_ovals(product_list, product_yamls, rule_obj): | |||
| oval_product, _ = os.path.splitext(oval_name) | |||
| oval_obj = {'name': oval_name, 'product': oval_product} | |||
|
|
|||
| platforms = ssg.oval.applicable_platforms(oval_path) | |||
| platforms = ssg.oval.applicable_platforms(oval_path, product=oval_product) | |||
There was a problem hiding this comment.
oval_product contains the directory name such as shared, firefox, jre, etc... it doesn't really contain a product per se. If the product is really relevant for the script, we should make it as a parameter and let cmake pass the right product. If we don't need it then we can just put some default value so it doesn't traceback.
There was a problem hiding this comment.
uhm... let me see what I can do
There was a problem hiding this comment.
Probably the default example product introduced in #7979 will do the trick on a good-enough level - the utility in question is not designed to be product-specific, so for the time being let's hope that usage of the default product won't impact its result.
There was a problem hiding this comment.
yeah, actually this PR is not needed any more.
ssh/oval.py'sapplicable_platformfails in some cases where aproduct is not detected since it needs to be rendered in jinja.
This adds a parameter that passes the product name and takes it into use
in
utils/rule_dir_json.py.Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com