Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for create srg export #7976

Merged
merged 5 commits into from
Dec 13, 2021

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Dec 8, 2021

Description:

Add docs for SRG export and in the process work for the RHEL8 STIG.

Rationale:

Improve documentation for the SRG export.

@Mab879 Mab879 added Documentation Update in project documentation. RHEL9 Red Hat Enterprise Linux 9 product related. labels Dec 8, 2021
@Mab879 Mab879 added this to the 0.1.60 milestone Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
OVAL definition file for rule 'xccdf_org.ssgproject.content_rule_security_patches_up_to_date' has changed from 'security-data-oval-com.redhat.rhsa-RHEL8.xml.bz2' to 'security-data-oval-com.redhat.rhsa-RHEL8.xml'.
OCIL for rule 'xccdf_org.ssgproject.content_rule_accounts_passwords_pam_faillock_deny' differs:
--- old datastream
+++ new datastream
@@ -1,5 +1,5 @@
 To ensure the failed password attempt policy is configured correctly, run the following command:
 $ grep pam_faillock /etc/pam.d/system-auth
 The output should show deny=.
- Is it the case that that is not the case?
+ Is it the case that limiting the number of failed logon attempts for users is not configured?
 
OCIL for rule 'xccdf_org.ssgproject.content_rule_accounts_passwords_pam_faillock_deny_root' differs:
--- old datastream
+++ new datastream
@@ -2,5 +2,5 @@
 attempts, run the following command:
 $ grep even_deny_root /etc/pam.d/system-auth
 The output should show even_deny_root.
- Is it the case that that is not the case?
+ Is it the case that limiting the number of failed logon attempts for the root user is not configured?


ocil: |-
To ensure that even the <tt>root</tt> account is locked after a defined number of failed password
attempts, run the following command:
<pre>$ grep even_deny_root /etc/pam.d/system-auth</pre>
The output should show <tt>even_deny_root</tt>.

fix: |-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention, then, to have fix be manual steps to remediate something? Can't we somehow derive this from the "Ansible" or "bash" remediations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention, then, to have fix be manual steps to remediate something?

Currently, yes

Can't we somehow derive this from the "Ansible" or "bash" remediations?

Possibly. I believe that we will still need to this key in some cases. But for cases where there are bash remediations we might be able to use those.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough.

@openshift-ci
Copy link

openshift-ci bot commented Dec 8, 2021

@Mab879: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-pci-dss 7ee48b6 link true /test e2e-aws-ocp4-pci-dss
ci/prow/e2e-aws-ocp4-moderate 7ee48b6 link true /test e2e-aws-ocp4-moderate
ci/prow/e2e-aws-rhcos4-moderate 7ee48b6 link true /test e2e-aws-rhcos4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JAORMX JAORMX merged commit 97f81d4 into ComplianceAsCode:master Dec 13, 2021
@marcusburghardt marcusburghardt added RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update in project documentation. RHEL8 Red Hat Enterprise Linux 8 product related. RHEL9 Red Hat Enterprise Linux 9 product related. STIG STIG Benchmark related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants