Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS: Introduce CIS controls file and take it into use #7968

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Dec 7, 2021

This introduces cis_eks.yml in the controls folder. This will be used
to do the EKS CIS assessment.

The controls were already taken into use in the cis and cis-node
profiles.

Signed-off-by: Juan Antonio Osorio Robles jaosorior@redhat.com

@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 7, 2021

/retest

@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 7, 2021

/retest

Copy link
Collaborator

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

controls/cis_eks.yml Outdated Show resolved Hide resolved
controls/cis_eks.yml Outdated Show resolved Hide resolved
controls/cis_eks.yml Outdated Show resolved Hide resolved
controls/cis_eks.yml Show resolved Hide resolved
controls/cis_eks.yml Outdated Show resolved Hide resolved
controls/cis_eks.yml Show resolved Hide resolved
Copy link
Contributor

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This introduces `cis_eks.yml` in the controls folder. This will be used
to do the EKS CIS assessment.

The controls were already taken into use in the cis and cis-node
profiles.

Signed-off-by: Juan Antonio Osorio Robles <jaosorior@redhat.com>
@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 8, 2021

Pull-request updated, HEAD is now 6086e2b

@JAORMX JAORMX force-pushed the eks-control-files branch from 708db49 to 6086e2b Compare December 8, 2021 06:52
@JAORMX
Copy link
Contributor Author

JAORMX commented Dec 8, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 8, 2021

@JAORMX: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-moderate-node 6086e2b link true /test e2e-aws-ocp4-moderate-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhmdnd
Copy link
Collaborator

rhmdnd commented Dec 8, 2021

Looks good, I think we can fix the nits in a follow up. Thanks!

@JAORMX JAORMX merged commit 25fdea4 into ComplianceAsCode:master Dec 8, 2021
@Mab879 Mab879 added this to the 0.1.60 milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants