-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSH host keys don't exist at bootable container build time #12755
Merged
jan-cerny
merged 1 commit into
ComplianceAsCode:master
from
matusmarhefka:ssh_host_keys
Dec 20, 2024
Merged
SSH host keys don't exist at bootable container build time #12755
jan-cerny
merged 1 commit into
ComplianceAsCode:master
from
matusmarhefka:ssh_host_keys
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add warnings to rules configuring SSH host keys permissions and ownership that remediation is not possible at bootable container build time because SSH host keys are generated post-deployment (only once bootable container is booted).
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_file_groupownership_sshd_private_key'.
--- xccdf_org.ssgproject.content_rule_file_groupownership_sshd_private_key
+++ xccdf_org.ssgproject.content_rule_file_groupownership_sshd_private_key
@@ -5,6 +5,10 @@
[description]:
SSH server private keys, files that match the /etc/ssh/*_key glob, must be
group-owned by ssh_keys group.
+
+[warning]:
+Remediation is not possible at bootable container build time because SSH host
+keys are generated post-deployment.
[reference]:
R50
New content has different text for rule 'xccdf_org.ssgproject.content_rule_file_groupownership_sshd_pub_key'.
--- xccdf_org.ssgproject.content_rule_file_groupownership_sshd_pub_key
+++ xccdf_org.ssgproject.content_rule_file_groupownership_sshd_pub_key
@@ -5,6 +5,10 @@
[description]:
SSH server public keys, files that match the /etc/ssh/*.pub glob, must be
group-owned by root group.
+
+[warning]:
+Remediation is not possible at bootable container build time because SSH host
+keys are generated post-deployment.
[reference]:
R50
New content has different text for rule 'xccdf_org.ssgproject.content_rule_file_ownership_sshd_private_key'.
--- xccdf_org.ssgproject.content_rule_file_ownership_sshd_private_key
+++ xccdf_org.ssgproject.content_rule_file_ownership_sshd_private_key
@@ -5,6 +5,10 @@
[description]:
SSH server private keys, files that match the /etc/ssh/*_key glob, must be owned
by root user.
+
+[warning]:
+Remediation is not possible at bootable container build time because SSH host
+keys are generated post-deployment.
[reference]:
R50
New content has different text for rule 'xccdf_org.ssgproject.content_rule_file_ownership_sshd_pub_key'.
--- xccdf_org.ssgproject.content_rule_file_ownership_sshd_pub_key
+++ xccdf_org.ssgproject.content_rule_file_ownership_sshd_pub_key
@@ -5,6 +5,10 @@
[description]:
SSH server public keys, files that match the /etc/ssh/*.pub glob, must be owned
by root user.
+
+[warning]:
+Remediation is not possible at bootable container build time because SSH host
+keys are generated post-deployment.
[reference]:
R50
New content has different text for rule 'xccdf_org.ssgproject.content_rule_file_permissions_sshd_private_key'.
--- xccdf_org.ssgproject.content_rule_file_permissions_sshd_private_key
+++ xccdf_org.ssgproject.content_rule_file_permissions_sshd_private_key
@@ -7,6 +7,10 @@
If those files are owned by the root user and the root group, they have to have the 0600 permission or stricter.
If they are owned by the root user, but by a dedicated group ssh_keys, they can have the 0640 permission or stricter.
+[warning]:
+Remediation is not possible at bootable container build time because SSH host
+keys are generated post-deployment.
+
[reference]:
12
New content has different text for rule 'xccdf_org.ssgproject.content_rule_file_permissions_sshd_pub_key'.
--- xccdf_org.ssgproject.content_rule_file_permissions_sshd_pub_key
+++ xccdf_org.ssgproject.content_rule_file_permissions_sshd_pub_key
@@ -4,6 +4,10 @@
[description]:
To properly set the permissions of /etc/ssh/*.pub, run the command: $ sudo chmod 0644 /etc/ssh/*.pub
+
+[warning]:
+Remediation is not possible at bootable container build time because SSH host
+keys are generated post-deployment.
[reference]:
12 |
Code Climate has analyzed commit 0709b7c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.6% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add warnings to rules configuring SSH host keys permissions and ownership that remediation is not possible at bootable container build time because SSH host keys are generated post-deployment (only once bootable container is booted).