Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule sysctl_kernel_yama_ptrace_scope to Ubuntu 24.04 CIS #12618

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 18, 2024

Description:

  • Added rule sysctl_kernel_yama_ptrace_scope to Ubuntu 24.04 CIS
  • Created a new variable sysctl_kernel_yama_ptrace_scope_value to allow the audit to pass on multiple values (1,2,3), whilst remediating to a single user-defined value.

Draft until issues with oval_feed_url are resolved (#12617)

In addition, a new variable was created (sysctl_kernel_yama_ptrace_scope_value)
to allow the audit to pass on multiple values (1,2,3), whilst
remediating to a single user-defined value.
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Used by openshift-ci bot. needs-ok-to-test Used by openshift-ci bot. labels Nov 18, 2024
Copy link

openshift-ci bot commented Nov 18, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 18, 2024

Code Climate has analyzed commit 581e1e3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@mpurg mpurg marked this pull request as ready for review November 19, 2024 08:15
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 19, 2024
@mpurg
Copy link
Contributor Author

mpurg commented Nov 19, 2024

Automatus tests are likely failing because sysctl cannot be set in a container and the test environment fails to prepare (related to #12511)

All rule tests pass locally on an Ubuntu2404 VM.

@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Nov 25, 2024
@dodys dodys self-assigned this Nov 25, 2024
@dodys dodys requested a review from a team November 25, 2024 15:23
@dodys dodys added this to the 0.1.76 milestone Nov 25, 2024
@dodys
Copy link
Contributor

dodys commented Nov 25, 2024

/packit build

@dodys dodys added Update Rule Issues or pull requests related to Rules updates. Update Profile Issues or pull requests related to Profiles updates. and removed Update Rule Issues or pull requests related to Rules updates. labels Nov 26, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@dodys dodys merged commit 3ed7d8d into ComplianceAsCode:master Nov 26, 2024
91 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants