Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined notes for BSI SYS.1.6.A16 #12529

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

lichtblaugue
Copy link

Description:

Added notes for BSI SYS.1.6 controls including scc rules

Rationale:

As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.

Copy link

openshift-ci bot commented Oct 23, 2024

Hi @lichtblaugue. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 23, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@jan-cerny jan-cerny added the OpenShift OpenShift product related. label Oct 25, 2024
@sluetze
Copy link
Contributor

sluetze commented Oct 28, 2024

LGTM

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an observation regarding the control status.
Otherwise looks good to me.

controls/bsi_sys_1_6.yml Outdated Show resolved Hide resolved
@yuumasato yuumasato self-assigned this Nov 29, 2024
@yuumasato yuumasato added this to the 0.1.76 milestone Nov 29, 2024
@yuumasato
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Nov 29, 2024
@yuumasato
Copy link
Member

@lichtblaugue Could you rebase so that the required tests that were not run are triggered?
Thank you.

Copy link

codeclimate bot commented Dec 3, 2024

Code Climate has analyzed commit f95750d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@yuumasato yuumasato merged commit 3081d84 into ComplianceAsCode:master Dec 9, 2024
104 of 106 checks passed
@yuumasato yuumasato added the BSI PRs or issues for the BSI profile. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSI PRs or issues for the BSI profile. ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants