-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix validation with OpenSCAP 1.4 #12303
Conversation
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
54c57a6
to
d72411c
Compare
Code Climate has analyzed commit d72411c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
Windows build will be fixed in #12303 |
I think we should explain this change here. OVALs in OCP4 and EKS products uses In other words, this change effectively preserves the current situation. The current situation is that OCP4 and EKS products contain invalid OVAL 5.11 and we don't run OVAL validation for them in the CTest. In OpenSCAP, we ship a custom OVAL 5.11.3 schema, where the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have build ocp4 product with OpenSCAP 1.4.0 and I have verified that the test isn't present in the CTest test.
Description:
Fix validation with OpenSCAP 1.4 by disabling
eks
andocp4
Always.Rationale:
Fix issues with the new OpenSCAP release.