-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ansible remediation for audispd plugin UBTU-20-010216 #11093
Add ansible remediation for audispd plugin UBTU-20-010216 #11093
Conversation
Hi @dexterle. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
...ng/configure_auditd_data_retention/auditd_audispd_configure_remote_server/ansible/ubuntu.yml
Outdated
Show resolved
Hide resolved
...ng/configure_auditd_data_retention/auditd_audispd_configure_remote_server/ansible/ubuntu.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the bash remediation is shared, so should the ansible.
This commit will add in ansible remediation for audispd plugin which also ensures that the plugin is enabled within au-remote.conf.
eaea06e
to
f214a16
Compare
Code Climate has analyzed commit f214a16 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 56.9%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now you should add the ubuntu specific bits, see bash
@dodys I was able to get in touch with a colleague who more recently spoke with @dexterle and they mentioned that they are focusing on other personal matters so if you all wouldn't mind helping taking the handful of open pull requests to the finish line I'd really appreciate it. Unfortunately these days I don't have any time to help personally but will continue to direct folks to help out. It's also worth noting that I have been doing my best to get vendors to contribute directly and have seen some success with SUSE so I'm focused on Canonical this next year. |
thanks for the heads up, I spoke with Dexter a month ago and we will be continuing his work. |
/packit test |
Could you resolve the conflict, please? |
@dexterle: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ping |
dexterle reached out last week about continuing work on this PRs, and I've asked to open new ones for a clean state. Therefore closing this one. |
Description:
Rationale:
Review Hints:
Build the product:
To test these changes with Ansible:
To test changes with bash, run the remediation sections:
xccdf_org.ssgproject.content_rule_auditd_audispd_configure_remote_server
Checkout Manual STIG OVAL definitions, and use software like DISA STIG Viewer to view definitions.
This STIG can not be tested with the latest Ubuntu 2004 Benchmark SCAP. Please perform a manual check given the check text. For reference, please review the latest artifacts: https://public.cyber.mil/stigs/downloads/