Re-run store_derived_evidence fetchers #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyshort
requested review from
alfinkel,
drsm79,
cletomartin,
mattwhite and
smithsz
as code owners
|
Good to hear from you Rhys. Is it possible to test the condition you describe? And show it fail before and succeed after the patch? |
|
Yeah, I'll get the test case written |
Ensure store_derived_evidence fetchers are re-run if dependant evidence is not yet available, this is achieved by get_evidence_dependency, rather than get_evidence_by_path.
|
done |
|
Thanks Rhys! |
cletomartin
approved these changes
Aug 20, 2024
|
@cletomartin I don't have commit rights, could you merge please? 😄 |
|
Merging, thanks @rhyshort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ensure store_derived_evidence fetchers are re-run if dependent evidence is not yet available, this is achieved by get_evidence_dependency, rather than get_evidence_by_path.
Why
When running fetchers that store derived evidence, they often rely on evidence from previous fetchers, however if this evidence is not available the fetcher fails and is not automatically re-run because the store_derived_evidence function does not treat source evidence as dependency that can be re-run.
How
get_evidence_by_pathcall toget_evidence_dependencycall in the decorator wrapper function.Test
Context