Fix notifier counts for single checks #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cletomartin
requested review from
alfinkel,
drsm79,
mattwhite and
smithsz
as code owners
cletomartin
commented
Feb 13, 2023
| @@ -66,12 +66,10 @@ def messages(self): | |||
| test_obj = test_desc["test"].test | |||
| method_name = parse_test_id(test_id)["method"] | |||
|
|
|||
| msg_method = "get_notification_message" | |||
| if len(test_obj.tests) > 1: | |||
There was a problem hiding this comment.
It can be applied as well to those tests with just one test_ method.
For those checks that only have one check_ method, the current code didn't show up correctly the number of errors/warnings correctly.
cletomartin
force-pushed
the
fix-notifiers-counts
branch
from
d157280 to
b5c355b
Compare
drsm79
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
For those checks that only have one check_ method, the current code didn't show up correctly the number of errors/warnings correctly.
Why
It wasn't working as expected.
How
Do not make a special case when calculating the message structure.
Test
Passing unit tests and update demo to ensure that this also happens.