Add Azure Cloud assessments for azure defender fetcher #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenli200133
requested review from
alfinkel,
drsm79 and
cletomartin
as code owners
cletomartin
reviewed
Feb 7, 2023
arboretum/__init__.py
Outdated
| @@ -13,4 +13,4 @@ | |||
| # limitations under the License. | |||
| """Arboretum - Checking your compliance & security posture, continuously.""" | |||
|
|
|||
| __version__ = "0.16.0" | |||
| __version__ = "0.16.1" | |||
There was a problem hiding this comment.
It's a new feature so I would bump it to 0.17.0
cletomartin
reviewed
Feb 7, 2023
cletomartin
reviewed
Feb 7, 2023
cletomartin
reviewed
Feb 7, 2023
cletomartin
reviewed
Feb 7, 2023
cletomartin
reviewed
Feb 7, 2023
| @@ -0,0 +1,4 @@ | |||
| """Common Azure constants.""" | |||
|
|
|||
| # AZURE management resource base url | |||
There was a problem hiding this comment.
No need for this comment.
cletomartin
reviewed
Feb 7, 2023
cletomartin
previously approved these changes
Feb 8, 2023
wenli200133
force-pushed
the
add-azure-fetcher
branch
from
1693a53
to
fa81ee3
Compare
wenli200133
force-pushed
the
add-azure-fetcher
branch
from
fa81ee3
to
7724f23
Compare
cletomartin
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add functionality of fetching assessments, sub-assessments and assessment metadata from Microsoft(Azure) Defender for Cloud.
Why
The assessments, sub-assessments and assessment metadata from Microsoft(Azure) Defender for Cloud can be used as evidence. For example the Azure user can use them to check healthy and unhealthy resources defined in Azure cloud and vulnerability issues in Azure Container Registry.
How
The fetchers in this PR get assessments, sub-assessments and assessment metadata list with Azure Cloud rest API and a valid Azure SPN.
Test
Provide a bulleted list of tests included in the pull request and/or tests
performed to validate the work included in the pull request.
Context
Provide a bulleted list of GitHub issues, or any other references (mailing list discussion, etc...) that reviewers can reference
for additional information regarding scope of the pull request.