Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ForAttributeWithMetadataName<T> when possible #436

Merged
merged 16 commits into from
Sep 16, 2022
Merged

Conversation

Sergio0694
Copy link
Member

Closes #424

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Sep 10, 2022
@Sergio0694 Sergio0694 changed the title se ForAttributeWithMetadataName<T> when possible Use ForAttributeWithMetadataName<T> when possible Sep 10, 2022
@Sergio0694 Sergio0694 force-pushed the dev/use-fawmn branch 3 times, most recently from 92abb58 to 6898cee Compare September 11, 2022 01:30
@Nirmal4G
Copy link
Contributor

Nirmal4G commented Sep 15, 2022

I'm actually trying to make the multi-targeting work via TargetFrameworks property by using a custom TargetFramework property (like: netstandard2.0-roslyn4.0). It's a work in progress as there's an issue with NuGet not accepting custom frameworks.

Another way is, trying to use Platform property (like: Roslyn v4.0) to specify Roslyn versions. This is the simplest one but it could confuse people. So, trying the former first.

If any of these solutions work, then much of the MSBuild project changes here no longer apply. We could maitain everything in a single project.

@Sergio0694
Copy link
Member Author

I'd really like to avoid messing with custom TFMs. Using a shared project is perfectly fine.

@Sergio0694 Sergio0694 merged commit 1de395c into main Sep 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/use-fawmn branch September 16, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ForAttributeWithMetadataName<T> when possible
2 participants