-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls.Media update winui version #4157
Conversation
Thanks RosarioPulella for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Thanks @RosarioPulella. I know we already tested these controls as part of the Sample App with the change, so this should just be a build issue to ensure they're being used when the package is alone. So don't expect any problems here once the build is done. 🙂 |
I think the build will fail. Since, we don't yet have the Design project for media controls. I'll add the Design project in #3794, which will make this change work. But for now, just update the WinUI version without the import. |
Thanks @Nirmal4G, update accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Fixes
Update winui version
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Microsoft.Toolkit.Uwp.UI.Controls.Media
uses winui 2.5What is the new behavior?
Microsoft.Toolkit.Uwp.UI.Controls.Media
uses winui 2.6.1PR Checklist
Please check if your PR fulfills the following requirements:
Other information