-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WinUI 2.6 Dependency to UnitTests.UWP App #4156
Conversation
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
@michael-hawker Please verify WinUI is properly imported by adding a WinUI resource lookup in the |
@huynhsontung I've added a check for that before the Window content is set, I've validated that it works fine locally. I'd be surprised if the app was having trouble with App.xaml in the CI as it does have to use that to not optimize the types we use (that was a problem we have had in the past). We'll see if this new commit succeeds in the pipeline. Otherwise, I'm wondering if it's the |
af048ae
to
db71796
Compare
@azchohfi not sure where the Logger outputs too as it's not the CI, maybe have to do the diagnostics file for that, though not sure if we want to do that every build? Anyway, it passed, so it's definitely finding the required resource for that component @huynhsontung. Probably not a bad idea to leave the check in the app startup so we know WinUI is initialized properly?? Thoughts? Think we can merge this PR then, and then rebase #3650 and see what happens? |
Hello @RosarioPulella! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Related to #3650
Splitting out the upgrade to WinUI 2.6 in the Unit Tests project to help try and isolate what might be going on.
Noticed some our other NuGet dependencies have updates as well, so if this works as-is, will try and update those as well.
Then we can check this in, and rebase #3650 to try and determine what else might be going on or pull in others to help investigate.
FYI @huynhsontung @azchohfi
PR Type
What kind of change does this PR introduce?
What is the current behavior?
WinUI 2.6 not included when we run unit tests
What is the new behavior?
WinUI 2.6 is now included when we run unit tests.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information