Update package titles and consolidate build logic #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Nirmal4G for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
Nirmal4G
changed the title
Nirmal4G
force-pushed
the
feature/refactor
branch
from
940a77c
to
a2c42f1
Compare
Nirmal4G
changed the title
Nirmal4G
changed the title
Nirmal4G
changed the title
Nirmal4G
force-pushed
the
feature/refactor
branch
3 times, most recently
from
021c9dd
to
b60b7de
Compare
Nirmal4G
changed the title
Nirmal4G
force-pushed
the
feature/refactor
branch
from
b60b7de
to
f874d2d
Compare
ghost
added
the
Nirmal4G
force-pushed
the
feature/refactor
branch
2 times, most recently
from
34b3c01
to
4a74699
Compare
Nirmal4G
force-pushed
the
feature/refactor
branch
2 times, most recently
from
5a28070
to
f06b480
Compare
This was referenced May 17, 2021
|
This looks to be built on #3893, so waiting for that to be finished before we look at this one. |
Nirmal4G
force-pushed
the
feature/refactor
branch
from
f06b480
to
8dc4a97
Compare
Nirmal4G
force-pushed
the
feature/refactor
branch
2 times, most recently
from
418f402
to
a38b58c
Compare
2 tasks
Nirmal4G
force-pushed
the
feature/refactor
branch
from
2905f58
to
7a63c15
Compare
michael-hawker
approved these changes
Jul 16, 2021
4 tasks
- Update comments to be more to the point. - Rearrange some lines in ascending order. - Add more file types and their preferences. - Rename missed files from previous renames.
Organize Package tags Update Package descriptions Remove redundant MSBuild logic Consolidate common MSBuild logic
Remove redundant MSBuild logic Consolidate common MSBuild logic Reorder code-blocks for better readability Fix-up comments and new-lines across project files Improve support for Visual Studio 2022: Since VS IDE 2022 (17.0) is 64-bit only, replace all 32-bit specific MSBuild properties with generic ones.
Remove redundant 'Exclude' as bin/obj doesn't exist in the Shared project. We use None to include items to be visible under the Shared Project in VS IDE. But having both None and Compile/Page includes for the same files will impact Build and IDE perf. So, Only include None when Compile/Page is already active.
Makes sure that global NoWarn(s) can be added/removed without editing each and every project file.
When the Controls project was exploded into several sub-projects, they were not marked for build in the solution file, leading to the missing of design tools assemblies in their respective control's packages. This patch updates the solution file with build options similar to what was already working, before the splitting of the Controls project.
Use same versions of dependencies across projects to ensure a consistent and predictable builds. This also fixes a Warning (NU1603) in the UI Test projects.
The package title doesn't follow a particular format and is not machine readable.
Thus, I propose the following format: "'Product' - 'Area' - 'Specifics' ('Source/Target')"
Remove targets that requires "DesignTools" check to let build succeed. Revert this patch when adding the actual "DesignTools" project for Media Controls.
VS IDE still adds this but its no longer needed!
Every "official" .NET packages use 'Icon' as its file name. Since, the icon file itself is public and older packages refer them by URL, we only change the file name during packaging which would be in the package.
It was decided that the term 'Basic' is new and has no established meaning in the software community. So, Replacing the term 'Basic' with 'Common'. To disambiguate multiple instances of 'Common', we use an already existing term 'Primitive' and we also append the Platform to which the package targets.
|
Apparently we have some merge conflicts now: It won't let me resolve them online here. |
Nirmal4G
force-pushed
the
feature/refactor
branch
from
7a63c15
to
6a12702
Compare
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Nirmal4G
force-pushed
the
feature/refactor
branch
2 times, most recently
from
c3fcfb9
to
e984265
Compare
michael-hawker
approved these changes
Jul 20, 2021
Microsoft.Toolkit.Uwp.UI.Controls.Core/Microsoft.Toolkit.Uwp.UI.Controls.Core.csproj
Show resolved
Hide resolved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3898
Icon.png(matching "official" dotnet packages).Also Fixes #3897
PR Type
What kind of change does this PR introduce?
What is the current behavior?
It's hard to read and understand the repo (because of the redundant files and logic). Package titles are messy. Packages doesn't contain
DesignToolsplugins.What is the new behavior?
It's now little bit better to read and understand the repo. Update Package titles to follow common (machine readable too) format. Packages now contain
DesignToolsplugins.PR Checklist
Please check if your PR fulfils the following requirements:
Other information
rebaseon latestHEADand then commit, without updating from the latestHEAD.Merge pull request #xxxx from repo/branch, and commit message to either PR message or messages of individual commits. Theauto-mergebot does this by default.