tokenize text box polish #3310
tokenize text box polish #3310
Conversation
add code to reset the caret position when using keyboard to navigate between pretoken text items
Note: This restricts us to 17763 due to the IconSourceElement I had to use (until WinUI 3).
|
Thanks marcpems for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned 
|
|
||
| if (_ttbEmailShowItems != null) | ||
| { | ||
| _ttbEmailShowItems.Click -= ShowButtonClick; | ||
| } | ||
|
|
||
| if (control.FindChildByName("ShowSelectedEmails") is Button showBtn) | ||
| { | ||
| _ttbEmailShowItems = showBtn; | ||
| _ttbEmailShowItems.Click += ShowButtonClick; | ||
| } |
There was a problem hiding this comment.
We can add this as a sample command if we want: https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/master/Microsoft.Toolkit.Uwp.SampleApp#5-for-interactive-buttons-use-samplecontrollercurrentregisternewcommand
There was a problem hiding this comment.
Same for the clear button
There was a problem hiding this comment.
I'll take a look at that in a subsequent PR as its part of the sample app.
Merging now to get this into the toolkit release.
thanks!
There was a problem hiding this comment.
Thanks, @marcpems looks good + @michael-hawker 's suggestion regarding adding as a sample command and clear button 🚀🚀
Fixes #
fixes this bug:
#3289 (comment)
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information