Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Follow-up] Remaining Items TODO for DesignTools Refactor #3620

Closed
7 tasks
michael-hawker opened this issue Dec 10, 2020 · 8 comments · Fixed by #4070
Closed
7 tasks

[Follow-up] Remaining Items TODO for DesignTools Refactor #3620

michael-hawker opened this issue Dec 10, 2020 · 8 comments · Fixed by #4070
Labels
Completed 🔥 in progress 🚧 maintenance ⚙️ visual studio 🔀
Milestone
7.1

Comments

@michael-hawker
Copy link
Member

michael-hawker commented Dec 10, 2020 •
edited by Kyaa-dost
Loading

Describe the bug

There were a few small issues remaining with PR #3318. This issue is to track the remaining open small items to resolve before release.

TODO

@Nirmal4G you still up for helping us finalize these bits? Since the majority of everything else was looking good, we just wanted to get the main PR merged so we could continue our other refactors.
@michael-hawker michael-hawker added this to the 7.0 milestone Dec 10, 2020
@ghost ghost removed the in progress 🚧 label Dec 10, 2020
@michael-hawker michael-hawker mentioned this issue Dec 10, 2020
Merged
3 tasks
@Nirmal4G
Copy link
Contributor

Sure. I'm okay with all the others except the TargetPlatform* properties.

@azchohfi
The reason I called the build number as Revision because it is the marker for the API "updates" or "revisions" in our case. It's a simpler term than what was used before.

@michael-hawker
Copy link
Member Author

@Nirmal4G Think you can get to some of these before we close down for the release in the next couple of weeks?

It'd at least be good to understand why the sperate Markdown package wasn't working as we're doing more work to split out the controls in #3660. Thanks!

@Nirmal4G
Copy link
Contributor

Nirmal4G commented Jan 8, 2021

Sure but before or after the mentioned PR?

Also, do we need to separate the Design projects similar to the controls projects too?

@michael-hawker
Copy link
Member Author

@Nirmal4G good point. We've broken ground on the PR, if you'd like to take a look at #3660 and see how the split out package looks, that'd be a great help, we'll do this for each of the sub-packages. I suppose it'll be easier to fix anything else afterwards once we've stabilized?

Though the Markdown package won't be touched in the meantime, so investigating that bug can probably still be done in the meantime? You could also start a Wiki Page with the background info for the Design Tools and how they work in general too. Thanks!

@michael-hawker
Copy link
Member Author

@Nirmal4G we've finished all the refactors to moving controls around, so if there's any polish or other clean-up you want to do in the next week before our final release, let us know. Thanks!

@Nirmal4G Nirmal4G mentioned this issue Feb 28, 2021
Merged
4 tasks
@ghost ghost added the In-PR 🚀 label Feb 28, 2021
@ghost ghost added the in progress 🚧 label Mar 2, 2021
@Nirmal4G
Copy link
Contributor

Nirmal4G commented Mar 6, 2021

@michael-hawker I can't mark the TODOs in the issue description!

@michael-hawker
Copy link
Member Author

@Nirmal4G sorry I guess it's because I filed the issue. Which ones would you like to mark off (or leave unmarked)?

@ghost ghost removed the in progress 🚧 label Mar 8, 2021
@Kyaa-dost
Copy link
Contributor

Wiki page is not included in #3794 @Nirmal4G if you get a chance can you please include the Wiki page as well explaining DesignTools and its functionality in the Wiki repo Will get that merged too with the rest of the changes in the #3794

@ghost ghost removed the In-PR 🚀 label Mar 14, 2021
@Kyaa-dost Kyaa-dost modified the milestones: 7.0, 7.1 Mar 16, 2021
@ghost ghost added the in progress 🚧 label Mar 16, 2021
@Nirmal4G Nirmal4G mentioned this issue Jun 17, 2021
Merged
2 tasks
@ghost ghost added the In-PR 🚀 label Jun 17, 2021
@ghost ghost closed this as completed in #4070 Aug 13, 2021
ghost pushed a commit that referenced this issue Aug 13, 2021
Add missing controls to Visual Studio Toolbox (#4070)
2d74076 
## Fixes #3620

Adds almost all the Controls in the toolkit packages to the Visual Studio Toolbox.

## PR Type

What kind of change does this PR introduce?

 - Bugfix
 - Feature
 - Code style update (formatting)
 - Build or CI related changes


## What is the current behavior?
Many controls don't appear in the VS IDE Toolbox.

## What is the new behavior?
The Controls now appear in the VS IDE Toolbox.


## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tested code with current [supported SDKs](../readme.md#supported)
- [x] Contains **NO** breaking changes


## Other information

 - If you're editing this patch tree, please `rebase` on latest `HEAD` and then commit, without updating from the latest `HEAD`.
 - When merging, please update the commit title to PR title instead of the default `Merge pull request #xxxx from repo/branch`, and commit message to either PR message or messages of individual commits. The `auto-merge` bot does this by default.
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Aug 13, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Completed 🔥 in progress 🚧 maintenance ⚙️ visual studio 🔀
Projects
None yet
Milestone
7.1
Development

Successfully merging a pull request may close this issue.

Add missing controls to Visual Studio Toolbox Nirmal4G/appkit-windows
3 participants
@Nirmal4G @michael-hawker @Kyaa-dost