SpeechRecognition fixes #2562
Open
SpeechRecognition fixes #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR fixes issues related to speech recognition support across multiple platforms by updating API usages and converting several void methods to asynchronous Tasks. Key changes include updating Android platform version requirements and adding asynchronous support with task-based patterns, as well as corresponding updates in macOS, iOS, .NET, Windows, and Tizen implementations.
Reviewed Changes
| File | Description |
|---|---|
| src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/OfflineSpeechToTextImplementation.android.cs | Converted InternalStartListening to async Task, updated Android version requirements, and added task-based callbacks for on-device language model download. |
| src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/SpeechToTextImplementation.android.cs | Updated language configuration and switched to async Task for InternalStartListening. |
| src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/OfflineSpeechToTextImplementation.macos.cs | Changed InternalStartListening to asynchronous, returning Task.CompletedTask. |
| src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/OfflineSpeechToTextImplementation.ios.cs | Converted InternalStartListening to async Task and returned Task.CompletedTask. |
| src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/OfflineSpeechToTextImplementation.net.cs | Updated InternalStartListening signature to Task and preserved unsupported behavior. |
| src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/OfflineSpeechToTextImplementation.windows.cs | Changed InternalStartListening to async Task with Task.CompletedTask return. |
| src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/OfflineSpeechToTextImplementation.tizen.cs | Updated InternalStartListening to async Task with Task.CompletedTask return. |
| src/CommunityToolkit.Maui.Core/Essentials/SpeechToText/OfflineSpeechToTextImplementation.shared.cs | Updated the StartListenAsync method to await the asynchronous InternalStartListening implementation. |
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
...munityToolkit.Maui.Core/Essentials/SpeechToText/OfflineSpeechToTextImplementation.android.cs
Show resolved
Hide resolved
...munityToolkit.Maui.Core/Essentials/SpeechToText/OfflineSpeechToTextImplementation.android.cs
Show resolved
Hide resolved
VladislavAntonyuk
added
the
needs discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
Untitled.video.2.mp4