Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG FIX: adding count check for navigation stack before getting last item, adding check for mainpage as current page as additional failover. #2379

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

BUG FIX: adding count check for navigation stack before getting last item, adding check for mainpage as current page as additional failover. #2379

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9e97cd8
adding count check for navigation stack before getting last-1, and ad…
Dec 11, 2024
059ff60
Merge branch 'main' into main
TheCodeTraveler Dec 18, 2024
7233d7d
Removing obsolete code for Application.Current.MainPage
nixkuroi Jan 3, 2025
bd197a8
Merge branch 'main' of https://github.com/nixkuroi/Maui
nixkuroi Jan 3, 2025
a720eea
Merge branch 'main' into main
ne0rrmatrix Jan 27, 2025
4a40dff
Merge branch 'main' into main
TheCodeTraveler Jan 29, 2025
1e51cc2
Merge branch 'main' into main
ne0rrmatrix Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CommunityToolkit.Maui.MediaElement/Views/MauiMediaElement.macios.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,12 +170,13 @@ static bool TryGetCurrentPage([NotNullWhen(true)] out Page? currentPage)
}

// If not using Shell or a Modal Page, return the visible page in the (non-modal) NavigationStack
if (window.Navigation.NavigationStack[^1] is Page page)
if (window.Navigation.NavigationStack.Count > 0 && window.Navigation.NavigationStack[^1] is Page page)
{
currentPage = page;
return true;
}


return false;

static bool TryGetModalPage(Window window, [NotNullWhen(true)] out Page? page)
Expand Down