Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to define when the IconTintBehavior gets applied #2304

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make it possible to define when the IconTintBehavior gets applied #2304

wants to merge 5 commits into from

Conversation

bijington
Copy link
Contributor

Description of Change

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@bijington bijington mentioned this pull request Oct 27, 2024
Open
2 tasks
bijington
bijington commented Oct 27, 2024
View reviewed changes
...unityToolkit.Maui/Behaviors/PlatformBehaviors/IconTintColor/IconTintColorBehavior.android.cs

bindable.Loaded += OnBindableLoaded;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we apply symmetry here and tidy up in Unloaded?

@dotnet-policy-service dotnet-policy-service bot added stale The author has not responded in over 30 days help wanted This proposal has been approved and is ready to be implemented labels Jan 17, 2025
ne0rrmatrix
ne0rrmatrix approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@ne0rrmatrix ne0rrmatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I have reviewed the changes. I have tested it on windows, ios, and android. It works as expected and fixes the bug reported. This looks good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ne0rrmatrix ne0rrmatrix ne0rrmatrix approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
help wanted This proposal has been approved and is ready to be implemented stale The author has not responded in over 30 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] IconTintColorBehavior is reset when navigate to another page then back
3 participants
@bijington @ne0rrmatrix @TheCodeTraveler