[BUG] Skipping the last item causes an error

[HarikalarKutusu]

While testing localization manually, I stumbled over this one.

To test:

1. Add 2-3 sentences
2. Skip them when reviewing
3. After the last item it gives error (but continues to work).

Console output in production (Windows/Chrome):

main.js:2 Error: Minified React error #300; visit https://reactjs.org/docs/error-decoder.html?invariant=300 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at ri (main.js:2)
at Fi (main.js:2)
at Vl (main.js:2)
at xu (main.js:2)
at ku (main.js:2)
at Eu (main.js:2)
at pu (main.js:2)
at main.js:2
at t.unstable_runWithPriority (main.js:2)
at Bo (main.js:2)

Console output in local (Ubuntu/Firefox):

Uncaught Error: Rendered fewer hooks than expected. This may be caused by an accidental early return statement.
React 12
unstable_runWithPriority scheduler.development.js:468
React 5
handleSwipe review-form.tsx:64
onSwipe review-form.tsx:167
swipe index.js:140
_callee2$ review-form.tsx:109
tryCatch runtime.js:63
invoke runtime.js:294
defineIteratorMethods runtime.js:119
__awaiter main.js:3078
__awaiter main.js:3057
processButtonPressOnCurrentCard review-form.tsx:98
handler review-form.tsx:124
SwipeReview review-form.tsx:128
React 5
unstable_runWithPriority scheduler.development.js:468
React 3
workLoop scheduler.development.js:417
flushWork scheduler.development.js:390
performWorkUntilDeadline scheduler.development.js:157
js scheduler.development.js:180
js scheduler.development.js:645
Webpack 11
react-dom.development.js:15050
The above error occurred in the component:

SwipeReview@http://localhost:3333/main.js:3092:16
div
Review@http://localhost:3333/main.js:3444:15
Route@http://localhost:3333/main.js:39000:29
PrivateRoute@http://localhost:3333/main.js:1045:16
Switch@http://localhost:3333/main.js:39206:29
main
Page@http://localhost:3333/main.js:2580:18
Router@http://localhost:3333/main.js:38629:30
ConnectedRouter@http://localhost:3333/main.js:4652:22
ConnectedRouterWithContext@http://localhost:3333/main.js:4776:19
ConnectFunction@http://localhost:3333/main.js:36799:68
App@http://localhost:3333/main.js:968:17
LocalizationProvider@http://localhost:3333/main.js:49310:9
AppLocalizationProvider@http://localhost:3333/main.js:4104:66
PersistGate@http://localhost:3333/main.js:42373:20
Provider@http://localhost:3333/main.js:36513:15
Store@http://localhost:3333/main.js:4547:17
Root

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://reactjs.org/link/error-boundaries to learn more about error boundaries. react_devtools_backend.js:2528:25
Uncaught (in promise) Error: Rendered fewer hooks than expected. This may be caused by an accidental early return statement.
React 12
unstable_runWithPriority scheduler.development.js:468
React 5
handleSwipe review-form.tsx:64
onSwipe review-form.tsx:167
swipe index.js:140
_callee2$ review-form.tsx:109
tryCatch runtime.js:63
invoke runtime.js:294
defineIteratorMethods runtime.js:119
__awaiter main.js:3078
__awaiter main.js:3057
processButtonPressOnCurrentCard review-form.tsx:98
handler review-form.tsx:124
SwipeReview review-form.tsx:128
React 5
unstable_runWithPriority scheduler.development.js:468
React 3
workLoop scheduler.development.js:417
flushWork scheduler.development.js:390
performWorkUntilDeadline scheduler.development.js:157
js scheduler.development.js:180
js scheduler.development.js:645
Webpack 11
react-dom.development.js:15050

[HarikalarKutusu]

Correction: It also happens in other combinations, not only in skip. On this line:

await cardsRefs[currentSentenceIndex].current.swipe(direction);

[MichaelKohler]

Thanks for filing this, nice catch! This is definitely a bug I introduced quite some time ago. Good that you found it!

I usually would tag this as "good first issue" for someone else to fix, but in this case the impact is quite bad, so I'm gonna fix this right now.

[MichaelKohler]

🎉 This issue has been resolved in version 2.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀