Skip to content

chore: cleanup metrics + cli #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 17, 2025
Merged

chore: cleanup metrics + cli #279

merged 4 commits into from
Mar 17, 2025

Conversation

ltitanb
Copy link
Collaborator

@ltitanb ltitanb commented Mar 16, 2025 •
edited
Loading

  • remove grafana, prometheus, and cAdvisor from the cb.docker-compose.yml, add a new Metrics page in the docs
  • remove the start, stop, logs commands from the cli

ref #273

@ltitanb ltitanb requested a review from ManuelBilbao March 16, 2025 22:25
@ltitanb ltitanb changed the title chore: cleanup metrics chore: cleanup metrics + cli Mar 16, 2025
ManuelBilbao
ManuelBilbao previously approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@ManuelBilbao ManuelBilbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just noted a few nit comments

ManuelBilbao
ManuelBilbao previously approved these changes Mar 17, 2025
View reviewed changes
@ltitanb ltitanb merged commit db135c8 into main Mar 17, 2025
2 checks passed
@ltitanb ltitanb deleted the ltitanb/cleanup-2 branch March 17, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuelBilbao ManuelBilbao ManuelBilbao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltitanb @ManuelBilbao