Skip to content

Conversation

ManuelBilbao
Copy link
Collaborator

Currently, Commit-Boost only support Lighthouse-like keystore, with a file structure similar to:

├── keys
│   ├── <PUBLIC_KEY_1>
│   │   └── voting-keystore.json
│   └── <PUBLIC_KEY_2>
│       └── voting-keystore.json
|── secrets
│   ├── <PUBLIC_KEY_1>
│   └── <PUBLIC_KEY_2>

This PR adds support for many other formats, like Prysm, Teku and Lodestar.
Solves a part of #17

@ManuelBilbao ManuelBilbao marked this pull request as ready for review November 26, 2024 18:53
Copy link
Collaborator

@ltitanb ltitanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Can we also add some tests using testdata generated by https://github.com/protolambda/eth2-val-tools

@ManuelBilbao ManuelBilbao requested a review from ltitanb December 2, 2024 13:28
@ltitanb ltitanb merged commit d24987f into Commit-Boost:main Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants