Skip to content

CBST-05: filter 204 responses #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

CBST-05: filter 204 responses #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/pbs/src/mev_boost/get_header.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,14 @@ async fn send_timed_get_header(
// ignore join error and timeouts, log other errors
res.ok().and_then(|inner_res| match inner_res {
Ok(maybe_header) => {
n_headers += 1;
Some(maybe_header)
if maybe_header.1.is_some() {
n_headers += 1;
Some(maybe_header)
} else {
// filter out 204 responses that are returned if the request
// is after the relay cutoff
None
}
}
Err(err) if err.is_timeout() => None,
Err(err) => {
Expand Down