build(dev): option for setting service image and volume names #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
2 times, most recently
from
46cebcc to
8c6122f
Compare
LCOV of commit
|
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
from
8c6122f to
d98b2f9
Compare
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
2 times, most recently
from
478d0d9 to
4899f89
Compare
LCOV of commit
|
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
from
4899f89 to
4a9a7d9
Compare
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
4 times, most recently
from
fc27fef to
f58f0bc
Compare
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
PiTrem
force-pushed
the
dev-docker-compose
branch
from
f58f0bc to
b6c4d24
Compare
- add optional var RAKE_DB_MIGRATE to run db:migrate instead of db:setup - also prevent multiple `yarn install`
PiTrem
force-pushed
the
dev-docker-compose
branch
from
bb63307 to
2734125
Compare
PiTrem
changed the title
copy compose files and env variable to .devcontainer and keep .env if present untouched as it was originaly for the rails app (dotenv)
PiTrem
force-pushed
the
dev-docker-compose
branch
from
2734125 to
9bab4b3
Compare
LCOV of commit
|
LCOV of commit
|
- set env variables in the docker-compose.dev.yml to allow using
- prebuild images for the app and skip the building process
- distinct postgres images
- distinct named volume for the db and homedir(asdf, gems, etc)
- remove image tags from dev docker compose file by yml overwrite for devcontainer
to be used instead of .env to have a better separation of variable for the configuring the docker env and variables to be used insides the services
PiTrem
force-pushed
the
dev-docker-compose
branch
from
9bab4b3 to
2bec0d5
Compare
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set env variables in the docker-compose.dev.yml to allow using
NB not applicable for devcontainer at this stage (see other PR that introduce build args)
.devcontainer/docker-compose.vs.yml reset the image tags
add .dockerenv.example file to help settings those variables
example
prevent .devcontainer to overwrite .env
separate var for docker environment vs services environments
rework the preparation scripts to better separate node packages
installation from ruby env installation. so that
yarn installis only run by the js container
add optional var RAKE_DB_MIGRATE to run db:migrate instead of db:setup when preparing the db
(see .dockerenv.example)