Fix PostgreSQL problem with given ids #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added some fix for sf 5 and replaced faker reference to fakerphp/faker |
|
Thank you @blafasel42! I haven't had much time to continue working on this package. If you want to become a maintainer, please let me know. |
|
Hi @MontealegreLuis ,
why not. I have a fork anyway. Works with sf6 and PHP8 and DBAL 3 now ;)
And it seems i am the only one using the package anyway...
|
|
Awesome! Just sent you an invite @blafasel42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres Driver will throw an exception when using lastInsertId() when the insert before had a primary key field set. i modified the DBALConnect to just ignore that exception (assignId() will ignore the assign anyway when the id field is already present in $row).
Now this works for me. Hope i did not miss anything.