Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on jQuery Knob Tron Style fires onClick event and changes skin #1091

Closed
blz-ea opened this issue Jun 29, 2016 · 1 comment
Closed

Comments

@blz-ea
Copy link

blz-ea commented Jun 29, 2016

I noticed when you click on a tron styled knob it triggers $("[data-skin]").on('click') event in demo.js and changes skin completely.

screenshot from 2016-06-29 10 00 41

This issue is related to data-skin attribute
<input type="text" class="knob" value="80" **data-skin="tron"** data-thickness="0.2" data-width="90" data-height="90" data-fgColor="#3c8dbc" data-readonly="true">
and to the line (1078) in inline.html:
if (this.$.data('skin') == 'tron') {

almasaeed2010 added a commit that referenced this issue Jul 1, 2016
@almasaeed2010
Copy link
Contributor

Fixed in master. This next minor release will contain the fix (2.3.4).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants