Implement basic google geocoding #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will make a call to the Google Maps geocoding API to get the canonical address text and latitude/longitude of the address.
|
As a note, this change by its nature ends up running some validation on addresses. If no actual addresses match the address text, it fails. If multiple addresses match the address text, it also fails. I think a good next step for me if we want to merge this in is to implement a way for ambiguous addresses to be resolved over sms and in the webform (#23), and for addresses which don't match any actual locations to properly handle their errors and ask for a retry. This way, we can confirm we have the correct address/location before sending out an alert. |
|
Resolves: #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make a call to the Google Maps geocoding API to get the
canonical address text and latitude/longitude of the address.