German reunification #396
Merged
German reunification #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to german-reunification
JackEPepper
approved these changes
Jul 4, 2023
DZappala
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JE for german reunification in form of a vote with its own custom gui
The goal was to create a system that could represent the historical reunification, but also completely different ahistorical situations
Is triggered:
If both Germanys are independent
or
If both Germanys or their overlords are in the same faction
or
By variable (currently unused)
Entitled to vote are:
Both Germanys
Their overlords
Great powers which belong to the same faction as the Germanys or their overlords
German releasables
More countries can be added via a variable list (currently unused)
The following can be voted on:
Unifier: GER|no reunification|DDR
Government system: like unifier|mix
Economic System: like unifier|mix
Faction: NATO|neutrality|Warsaw Pact
Compulsion to reduce unemployment in the new states: yes|no
Claims on eastern europe: yes|no
The voting power is the prestige of the countries
The AI is weighted to vote realistically, but not predictable
Finally, the two German states must agree to the unification treaty
Should reunification take place, releasables can also join the united Germany
I'm still a bit unhappy with some things like optimization or the successor JE, but it's good enough for the alpha and probably for the beta as well