Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error fixing #247

Merged
merged 16 commits into from
Apr 23, 2023
Merged

Error fixing #247

merged 16 commits into from
Apr 23, 2023

Conversation

Matti-96
Copy link
Contributor

fixing errors that appeared in the error logs when playing the dev branch

Matti-96 added 14 commits April 22, 2023 03:24
multiple fixes for errors that are listed in the error log on game start
- changed naval to navy to match the modifier type
- added missing agriculture building group throughput mult modifier
- fixed modifiers in production technologies
- added state_radicals_from_conquest_mult to 00_modifier_types.txt
- commented out country_criminals from society tech drug_revolution as they aren't being used
- added missing building_modifiers scope for military PMs:
-- pm_wartime_battlesuite
-- pm_c3_human_control
-- pm_c3_technology_enhanced_human_control
-- pm_c3_computer_controlled
-- pm_ai_naval_command
- hopefully ai won't destroy their infrastructure now
- state_migration_pull_mult is the correct modifier instead of state_migration_attraction_mult
- removed all mentions of generates_residences from common/buildings folder
@github-actions github-actions bot requested review from Arcadyi and DZappala April 22, 2023 23:59
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Apr 23, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log or 👼 SARIF report for details.

Unrecognized words (7028)

Truncated, please see the log or artifact if available.

Some files were automatically ignored

Truncated, please see the log or artifact if available.

To accept ✔️ these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:Cold-War-Project/CWP-Main.git repository
on the error-fixing branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Cold-War-Project/CWP-Main/actions/runs/4776068981/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words not in the 📘 dictionary
Dictionary Entries Covers
cspell:filetypes/filetypes.txt 264 3
cspell:css/css.txt 190 2
cspell:scala/scala.txt 833 1
cspell:r/src/r.txt 808 1
cspell:npm/npm.txt 288 1
cspell:monkeyc/src/monkeyc_keywords.txt 1221 1
cspell:mnemonics/src/mnemonics.txt 800 1
cspell:lorem-ipsum/dictionary.txt 240 1
cspell:cryptocurrencies/cryptocurrencies.txt 123 1

Consider adding them using (in .github/workflows/spelling.yml):

      with:
        extra_dictionaries:
          cspell:filetypes/filetypes.txt
          cspell:css/css.txt
          cspell:scala/scala.txt
          cspell:r/src/r.txt
          cspell:npm/npm.txt
          cspell:monkeyc/src/monkeyc_keywords.txt
          cspell:mnemonics/src/mnemonics.txt
          cspell:lorem-ipsum/dictionary.txt
          cspell:cryptocurrencies/cryptocurrencies.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
Errors (7)

See the 📂 files view, the 📜action log or 👼 SARIF report for details.

❌ Errors Count
ℹ️ binary-file 2085
❌ check-file-path 138
❌ forbidden-pattern 22
ℹ️ large-file 174
ℹ️ minified-file 2
ℹ️ noisy-file 5
ℹ️ unexpected-line-ending 2

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@JackEPepper JackEPepper merged commit b91e788 into dev Apr 23, 2023
@JackEPepper JackEPepper deleted the error-fixing branch April 23, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants