Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix japan event #241

Merged
merged 4 commits into from
Apr 23, 2023
Merged

fix japan event #241

merged 4 commits into from
Apr 23, 2023

Conversation

AnimeDalit97
Copy link
Contributor

The event should remove the modifier demilitarized_nation for japan

Arcadyi and others added 3 commits April 21, 2023 03:47
The event should remove the modifier demilitarized_nation for japan
fix: remove demilitarized_nation in the event
@github-actions

This comment has been minimized.

@AnimeDalit97 AnimeDalit97 changed the base branch from master to dev April 22, 2023 10:51
@DZappala
Copy link
Member

Isn't Japan meant to remain demilitarized until it's able to hold some (potential) referendum on the interpretation of Article 9? Historically this wasn't until 2014.

@AnimeDalit97
Copy link
Contributor Author

Isn't Japan meant to remain demilitarized until it's able to hold some (potential) referendum on the interpretation of Article 9? Historically this wasn't until 2014.

JGSDF is created in 1954..

@DZappala DZappala requested review from Arcadyi and DZappala April 23, 2023 02:54
@github-actions
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log or 👼 SARIF report for details.

Unrecognized words (7029)

Truncated, please see the log or artifact if available.

Some files were automatically ignored

Truncated, please see the log or artifact if available.

To accept ✔️ these unrecognized words as correct, run the following commands

... in a clone of the git@github.com:AnimeDalit97/CWP-Main.git repository
on the master branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Cold-War-Project/CWP-Main/actions/runs/4776076366/attempts/1'
Available 📚 dictionaries could cover words not in the 📘 dictionary
Dictionary Entries Covers
cspell:filetypes/filetypes.txt 264 3
cspell:css/css.txt 190 2
cspell:scala/scala.txt 833 1
cspell:r/src/r.txt 808 1
cspell:npm/npm.txt 288 1
cspell:monkeyc/src/monkeyc_keywords.txt 1221 1
cspell:mnemonics/src/mnemonics.txt 800 1
cspell:lorem-ipsum/dictionary.txt 240 1
cspell:cryptocurrencies/cryptocurrencies.txt 123 1

Consider adding them using (in .github/workflows/spelling.yml):

      with:
        extra_dictionaries:
          cspell:filetypes/filetypes.txt
          cspell:css/css.txt
          cspell:scala/scala.txt
          cspell:r/src/r.txt
          cspell:npm/npm.txt
          cspell:monkeyc/src/monkeyc_keywords.txt
          cspell:mnemonics/src/mnemonics.txt
          cspell:lorem-ipsum/dictionary.txt
          cspell:cryptocurrencies/cryptocurrencies.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
Errors (7)

See the 📂 files view, the 📜action log or 👼 SARIF report for details.

❌ Errors Count
ℹ️ binary-file 2085
❌ check-file-path 138
❌ forbidden-pattern 22
ℹ️ large-file 174
ℹ️ minified-file 2
ℹ️ noisy-file 5
ℹ️ unexpected-line-ending 2

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@JackEPepper JackEPepper merged commit 54cd1c6 into Cold-War-Project:dev Apr 23, 2023
@JackEPepper
Copy link
Member

Seems like a good stopgap for japan players until we implement the new law rework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants