This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
Container selector option #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmdotdev
reviewed
Sep 24, 2019
anmdotdev
reviewed
Sep 24, 2019
anmdotdev
reviewed
Sep 24, 2019
src/index.js
Outdated
| @@ -9,7 +9,7 @@ import './styles/styles.css'; | |||
| let ctToastCount = 0; | |||
|
|
|||
| const cogoToast = (text, options) => { | |||
| let rootContainer = document.getElementById('ct-container'); | |||
| let rootContainer = document.querySelector(options.containerCssSelector) || document.getElementById('ct-container'); | |||
There was a problem hiding this comment.
Can we change it to toastContainerID, where we could pass the ID instead of a CSS selector
anmdotdev
reviewed
Sep 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for creating this library.
I have the case when I'd like to render the toast message and position it relative to the element within the iframe, so adding
ct-containerid won't work asdocument.getElementById('ct-container')is executed in the main window.This change allows passing an option of a container css selector.