Minor improvements for NER and MD #570
Merged
+67
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support reading brown-clusters from local resource
danyaljj
reviewed
Oct 19, 2017
| if (!checker.exists()){ | ||
| bcFilePath = pathsToClusterFiles.elementAt(i); | ||
| } | ||
| InputStream is = new FileInputStream(bcFilePath); |
There was a problem hiding this comment.
@Slash0BZ this can could confusions. (for people thay may think that it is reading from datastore, but it is in fact reading locally).
How about your add a switch to the configurator (say boolean readFromDataStore, with default value of true) and use it here? (rather than checking datastore to see if the file exists or not).
There was a problem hiding this comment.
Ok that makes more sense.
|
Looks good to me. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support reading brown-clusters from local resource in ner.ExpressiveFeatures.BrownClusters
add a helper function in ColumnFormatReader that transforms TextAnnotation to ColumnFormat