Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Audio] Embed colours now respect what the user set #2046

Merged
merged 5 commits into from
Aug 26, 2018

Conversation

Brramble
Copy link
Contributor

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

All embeds in audio will now respect ctx.embed_colour()

@Tobotimus Tobotimus added Type: Enhancement Something meant to enhance existing Red features. QA: Needed labels Aug 26, 2018
@Tobotimus Tobotimus self-assigned this Aug 26, 2018
@Tobotimus Tobotimus self-requested a review August 26, 2018 02:46
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! Congrats on your first PR 🎉

@Tobotimus Tobotimus added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). and removed QA: Needed labels Aug 26, 2018
@Tobotimus Tobotimus added this to the Beta 20 milestone Aug 26, 2018
@Tobotimus Tobotimus merged commit 0aca00b into Cog-Creators:V3/develop Aug 26, 2018
@Brramble
Copy link
Contributor Author

💃 Woo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants