[V3/report] patch issue with attatchment grabbing #1822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
This makes 2 changes: both aimed at fixing #1816
The first in report's logic to ensure the attachment is grabbed prior to message deletion
The second in mod's logic to move the delete delay to trigger on command completion or command error instead of on_command. This prevents past issues like #1652 (fixed in an alternate way) as well as any future issues in which the message object has to be interacted with in the command.