Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 CLI] CLI prefix args correctly display in the on_ready print #1770

Merged
merged 2 commits into from
Jun 2, 2018
Merged

[V3 CLI] CLI prefix args correctly display in the on_ready print #1770

merged 2 commits into from
Jun 2, 2018

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Jun 2, 2018

fixes #1477,

This also includes a fix which prevents the CLI from dumping a traceback if it can't detect versions by modifying the scope of the preexisting try/except block slightly. This was necessary to actually test this currently, but there's no obvious downside to keeping it as this is directly related to what was previously in the block (a conditional attempt to message the owner on outdated launch)

This would also fix #1742

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

@tekulvw tekulvw merged commit 741f3cb into Cog-Creators:V3/develop Jun 2, 2018
@Tobotimus Tobotimus added the V3 label Jun 3, 2018
@mikeshardmind mikeshardmind deleted the iss1477 branch December 26, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] - Invalid version number. [V3] CLI prefix display
3 participants