[V3 ping] fixes reaction on message deletedelay of zero #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point it may be easier to revert to the initial implementation. I was originally OK with the reaction because it could be considered a "spam" prevention measure since the bot didn't need to send a message to communicate responsiveness. However, now I just don't think the added complexity is worth it especially considering now we've moved away from the "shortest code path possible" to getting a response from the bot. My vote is to revert. |
|
I don't think keeping the maybe embed portion is worth it because the word pong doesn't need to be inside an embed, it can just be plain text. |
Kowlin
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Put's the ping command back to only responding with "Pong." per @tekulvw 's decision in discord.