Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiscores indexing issues: #38

Closed
johnnydhnguyen opened this issue Mar 31, 2023 · 3 comments
Closed

hiscores indexing issues: #38

johnnydhnguyen opened this issue Mar 31, 2023 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@johnnydhnguyen
Copy link

I've noticed that whilst running a for through each boss name in the dictionary provided in the code, everything after obor shifts one index to the right.

After debugging, I found that this may be due to the phantom muspah update has caused an issue in indexing when calling onto the osrs hiscores api.

@Coffee-fueled-deadlines
Copy link
Owner

I've noticed that whilst running a for through each boss name in the dictionary provided in the code, everything after obor shifts one index to the right.

After debugging, I found that this may be due to the phantom muspah update has caused an issue in indexing when calling onto the osrs hiscores api.

Thank you for pointing this out. I had a feeling that this would be something that would, honestly, come to be common-place due to jagex's janky excuse for a hiscores page.

I'll push out a fix this weekend.

@johnnydhnguyen
Copy link
Author

I fixed the issue on my end, what you can do is to go into hiscores.py

right under "obor" in the parseBosses function, add in "phantom_muspah". Should fix the issue instantly.

@Coffee-fueled-deadlines Coffee-fueled-deadlines added bug Something isn't working good first issue Good for newcomers labels Apr 2, 2023
Coffee-fueled-deadlines added a commit that referenced this issue Apr 3, 2023
Added entry for Phantom Muspah as per issue #38
@Coffee-fueled-deadlines
Copy link
Owner

Fixed as of this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants