Configurable precision for multiply / divide float-string

Codito-Dev · Feb 27, 2022 · 3868f64 · 3868f64
1 parent d497186
commit 3868f64
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 4 deletions.
diff --git a/composer.json b/composer.json
@@ -21,7 +21,8 @@
         "phpunit/phpunit": "^9.5",
         "rector/rector": "^0.12",
         "symfony/dependency-injection": "^5.4|^6.0",
-        "symplify/easy-coding-standard": "^10.0"
+        "symplify/easy-coding-standard": "^10.0",
+        "webmozart/assert": "^1.10"
     },
     "autoload": {
         "psr-4": {

diff --git a/src/Rule/MultiplyAndDivideByStringRector.php b/src/Rule/MultiplyAndDivideByStringRector.php
@@ -14,13 +14,19 @@
 use PHPStan\Analyser\MutatingScope;
 use PHPStan\Type\FloatType;
 use PHPStan\Type\ObjectType;
+use Rector\Core\Contract\Rector\AllowEmptyConfigurableRectorInterface;
 use Rector\Core\Rector\AbstractRector;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
-final class MultiplyAndDivideByStringRector extends AbstractRector
+final class MultiplyAndDivideByStringRector extends AbstractRector implements AllowEmptyConfigurableRectorInterface
 {
+    public const PRECISION = 'precision';
+
+    private int $precision;
+
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
@@ -79,7 +85,7 @@ public function refactor(Node $node): ?Node
                 $firstArg->value = $this->nodeFactory->createFuncCall(
                     'sprintf',
                     [
-                        '%.5F',
+                        sprintf('%%.%dF', $this->precision),
                         $firstArgValue,
                     ]
                 );
@@ -91,6 +97,11 @@ public function refactor(Node $node): ?Node
         return null;
     }
 
+    public function configure(array $configuration): void
+    {
+        Assert::nullOrInteger($this->precision = $configuration[self::PRECISION] ?? 5);
+    }
+
     private function shouldSkip(MethodCall $node): bool
     {
         /** @var ObjectType $executedOn */

diff --git a/tests/Rule/MultiplyAndDivideByStringRector/config/configured_rule.php b/tests/Rule/MultiplyAndDivideByStringRector/config/configured_rule.php
@@ -10,5 +10,8 @@
 
     $services = $containerConfigurator->services();
 
-    $services->set(MultiplyAndDivideByStringRector::class);
+    $services->set(MultiplyAndDivideByStringRector::class)
+        ->configure([
+            MultiplyAndDivideByStringRector::PRECISION => 5,
+        ]);
 };