Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint #23

Merged
merged 5 commits into from
Aug 16, 2016
Merged

Update eslint #23

merged 5 commits into from
Aug 16, 2016

Conversation

randycoulman
Copy link
Contributor

@randycoulman randycoulman commented Aug 16, 2016

  • Upgrade eslint-plugin-import to v1.13.0
    • Adds support for new rule import/no-restricted-paths, but leaves it disabled
  • Upgrade eslint-plugin-react to v6.1.1
    • Add support for new rules: react/forbid-component-props (disabled by default), react/no-danger-with-children, and react/no-find-dom-node.
    • Rename react/wrap-multilines to react/jsx-wrap-multilines
    • Rename react/no-comment-textnodes to react/jsx-no-comment-textnodes
    • Remove deprecated react/require-extension rule.
  • Upgrade eslint to v3.3.1
    • Add support for new rules: no-template-curly-in-string, multiline-ternary (disabled by default), no-tabs, sort-keys (disabled by default)
    • Replace deprecated rules with their replacements: no-negated-in-lhs -> no-unsafe-negation, no-native-reassign -> no-global-assign, no-spaced-func -> func-call-spacing

* Rename `find-new-rules` script to `missing-rules` - simpler, and
clearer about its purpose.
* Use latest babel-eslint
* Use latest eslint-find-rules
* Latest eslint-find-rules adds a new `—no-core` option which
simplifies our `missing-rules` script.
Adds support for new rule `import/no-restricted-paths`, but leaves it
disabled
* Add support for new rules: `react/forbid-component-props` (disabled
by default), `react/no-danger-with-children`, and
`react/no-find-dom-node`.
* Rename `react/wrap-multilines` to `react/jsx-wrap-multilines`
* Rename `react/no-comment-textnodes` to
`react/jsx-no-comment-textnodes`
* Remove deprecated `react/require-extension` rule.
This rule has a bug when working with spread properties (see
jsx-eslint/eslint-plugin-react#771).

Temporarily disable the rule to avoid the bug for now.
* Add support for new rules:
  * `no-template-curly-in-string`
  * `multiline-ternary` (disabled by default)
  * `no-tabs`
  * `sort-keys` (disabled by default)
* Replace deprecated rules with their replacements:
  * `no-negated-in-lhs` -> `no-unsafe-negation`
  * `no-native-reassign` -> `no-global-assign`
  * `no-spaced-func` -> `fund-call-spacing`
@randycoulman randycoulman merged commit 1ff2297 into master Aug 16, 2016
@randycoulman randycoulman deleted the update-eslint branch August 16, 2016 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant