Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate displayName, use name property (Android) #326

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

itsLucario
Copy link
Contributor

@itsLucario itsLucario commented Nov 26, 2023

Google SignIn result return "displayName" (Basically full name) but the User container property "name" which is never populated.
Ref:


image

closes #73

@reslear
Copy link
Collaborator

reslear commented Nov 26, 2023

good, maybe better to rename displayName -> name for Android and deprecate displayName for backward compatibility:

closes #73
first mention: #10 (comment)

@reslear reslear changed the title fix: User should contain displayName property fix: deprecate android displayName property Nov 26, 2023
@reslear reslear changed the title fix: deprecate android displayName property refactor: deprecate displayName, use name property (Android) Nov 26, 2023
@reslear
Copy link
Collaborator

reslear commented Nov 26, 2023

@itsLucario congratulations thanks for your contribution ;)

@reslear reslear merged commit dece438 into CodetrixStudio:master Nov 26, 2023
Houssemtak89 pushed a commit to Houssemtak89/CapacitorGoogleAuth that referenced this pull request Dec 18, 2023
…etrixStudio#326)

* fix: User should contain displayName property

* unify and deprectate

---------

Co-authored-by: reslear <reslear@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to User interface
2 participants