This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
Fix lack of anchor support #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cdf-website ready! Built with commit c289fde |
The app needs to know to look in /node_modules for stuff, and I wasn't sure how to configure that.
This forces the browser location to add in the hash, causing it to scroll to the correct place. nextTick is used to cause this to happen on the next dom update, which works, I think
DanielBrierton
approved these changes
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, anchors do not work in chrome/safari. e.g. https://coderdojo.com/ways-to-run/#online does not scroll the page down to the Online section, despite the
divhaving the correct id.In the end I opted for a solution which cause the browser to update its href (probably) after the dom has loaded.
Preview URLs
https://deploy-preview-73--cdf-website.netlify.app/ways-to-run/#online
https://deploy-preview-73--cdf-website.netlify.app/ways-to-run/#in-person
https://deploy-preview-73--cdf-website.netlify.app/ways-to-run/#remote
What's changed
yarn updateran<Questions />section in ways-to-run (probably copy-pasta)