Skip to content

Commit

Permalink
Remove workarounds for check_podspecs needed for older version of C…
Browse files Browse the repository at this point in the history
…ocoapods (flutter#5724)

CI has been updated to Cocoapods 1.13, which fixes previous issues with the plugin_lint_mac test. Remove workarounds added previously.

See flutter#125812.
  • Loading branch information
vashworth authored Dec 20, 2023
1 parent dc5b267 commit 4c3bc49
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
3 changes: 0 additions & 3 deletions script/tool/lib/src/podspec_check_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,6 @@ class PodspecCheckCommand extends PackageLoopingCommand {
podspecPath,
'--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices.
'--skip-tests',
// TODO(vashworth): remove allow-warnings when https://github.com/flutter/flutter/issues/125812 is fixed.
// https://github.com/flutter/flutter/issues/125812
'--allow-warnings',
'--use-modular-headers', // Flutter sets use_modular_headers! in its templates.
if (libraryLint) '--use-libraries'
];
Expand Down
4 changes: 0 additions & 4 deletions script/tool/test/podspec_check_command_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
'--use-modular-headers',
'--use-libraries'
],
Expand All @@ -159,7 +158,6 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
'--use-modular-headers',
],
packagesDir.path),
Expand Down Expand Up @@ -201,7 +199,6 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
'--use-modular-headers',
'--use-libraries'
],
Expand All @@ -217,7 +214,6 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
'--use-modular-headers',
],
packagesDir.path),
Expand Down

0 comments on commit 4c3bc49

Please sign in to comment.