-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace react-clipboard.js to react-copy-to-clipboard package #973
Open
wrspada02
wants to merge
334
commits into
master
Choose a base branch
from
fix/issue-923
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om enzyme to react-testing-library
…nzyme to react-testing-library
…t-testing-library
…pec.js from enzyme to react-testing-library
…nzyme to react-testing-library
…ct-testing-library
… react-testing-library
…ct-testing-library
…e to react-testing-library
…ct-testing-library
… react-testing-library
…ct-testing-library
…oad changesets when last_changset_id is changed' from sinon.fakeServer to msw
…ce if present in multiple changesets' from sinon.fakeServer to msw
…changesets' it 'should load new stories from changesets'
…t-testing-library
…ful-dnd component
…attribute for the children as string as type declared
…on file sprint_spec.js
… history_item_spec.js
…ary logs file search_spec.js
…for Sprints component on file sprints_spec.js
…sk on file expanded_story_task_spec.js
…ional since it does not have to use showHistory everytime it renders
…on file expanded_story_notes_spec.js for not logging warnings
…spec.js to not log warnings
…with correct data
…not log warnings on the console
This reverts commit 58fbdfd.
…ies and replace last sinon.fakeServer for msw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do ?
Replace react-clipboard.js to react-copy-to-clipboard package
Related Issues
#923
Screenshots (if applicable)
Additional Notes (if any)
Besides the above prints I tested it manually, looks good. The functionality works well and the html, css are good.
We have to wait for this PR be merged: #968
It comes with fix/issue-908 branch changes because we should have the new vitest config setup to upgrade node version