Skip to content

Minor fixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2018
Merged

Minor fixes #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76a3b9b
Update Composer release date
JavierCane Jul 18, 2018
dc73aa7
Fix PhpUnit test suite name
JavierCane Jul 18, 2018
8a82618
Set `Codelyber#GREETING` constant as private in order to encapsulate …
JavierCane Jul 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .semver
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
:major: 1
:minor: 2
:patch: 0
:patch: 1
:special: ''
10 changes: 5 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "codelytv/php-bootstrap",
"description": "Starting point if you want to bootstrap a project in PHP.",
"description": "Starting point if you want to bootstrap a project in PHP following best practices.",
"type": "project",
"keywords": [
"bootstrap",
Expand All @@ -9,20 +9,20 @@
"TDD",
"boilerplate"
],
"homepage": "http://codely.tv",
"time": "2016-09-18",
"homepage": "https://codely.tv",
"time": "2018-07-18",
"license": "MIT",
"authors": [
{
"name": "Javier Ferrer",
"email": "javier.ferrer@codely.tv",
"homepage": "http://codely.tv",
"homepage": "https://codely.tv",
"role": "Developer"
},
{
"name": "Rafa Gómez",
"email": "rafa.gomez@codely.tv",
"homepage": "http://codely.tv",
"homepage": "https://codely.tv",
"role": "Developer"
}
],
Expand Down
2 changes: 1 addition & 1 deletion phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
beStrictAboutTestSize="true"
beStrictAboutChangesToGlobalState="true">
<testsuites>
<testsuite name="finderKata">
<testsuite name="phpBootstrap">
<directory>tests</directory>
</testsuite>
</testsuites>
Expand Down
2 changes: 1 addition & 1 deletion src/Codelyber.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
final class Codelyber
{
/** string */
const GREETING = "CodelyTV";
private const GREETING = "CodelyTV";

/** @var string */
private $name;
Expand Down