Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow closing the upsell modal for Custom Layout #4371

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jan 30, 2025

Summary

Allow the user to close the modal for Custom Layout upsell. The modal appears every time the user enters the page, and if it is closed, it reappears if the user presses on Add New Layout.

Will affect visual aspect of the product

YES

Screenshots

2025-01-30_16-59-06.mp4

Test instructions

  • Check the upsell modal close workflow.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2927

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jan 30, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review January 30, 2025 16:17
@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Jan 30, 2025
@pirate-bot
Copy link
Collaborator

Plugin build for 3b92fb3 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 30, 2025
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Jan 30, 2025
@abaicus abaicus merged commit 1f2ab00 into development Feb 3, 2025
21 of 25 checks passed
@abaicus abaicus deleted the refactor/custom-layout-modal branch February 3, 2025 09:18
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 4.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants